resistor-color-duo: no tests for green or red #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacG
approved these changes
Mar 28, 2020
|
|
This isn’t a bug-fix, so merging is blocked by #1560, I’m afraid. |
I had a student submit a solution where red was missing. For completeness, adding a test for white and red.
glennj
force-pushed
the
glennj-patch-resistor-color-duo-red-green
branch
from
3b0de75 to
56e1f36
Compare
|
Rebased to pull in UUIDS. |
ErikSchierboom
approved these changes
Oct 14, 2020
SleeplessByte
approved these changes
Oct 14, 2021
|
Finally merged 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a student submit a solution where red was missing. For completeness, adding a test for green and red.
Parenthetically, us red-green colourblind folks will appreciate the automated assistance: I had significant difficulties with my first-year electronics course.